Skip to content

[CDAPI-72]: implemented pdm client#99

Merged
MohammadPatelNHS merged 1 commit intomainfrom
feature/CDAPI-72
Apr 20, 2026
Merged

[CDAPI-72]: implemented pdm client#99
MohammadPatelNHS merged 1 commit intomainfrom
feature/CDAPI-72

Conversation

@MohammadPatelNHS
Copy link
Copy Markdown
Contributor

@MohammadPatelNHS MohammadPatelNHS commented Apr 13, 2026

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • Exceptions/Exclusions to coding standards (e.g. #noqa or #NOSONAR) are included within this Pull Request.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@MohammadPatelNHS MohammadPatelNHS force-pushed the feature/CDAPI-72 branch 3 times, most recently from fbcdca3 to 923a897 Compare April 14, 2026 15:20
Copy link
Copy Markdown
Collaborator

@nhsd-jack-wainwright nhsd-jack-wainwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor questions/suggestions

Comment thread mocks/src/pdm_mock/handler.py Outdated
Comment thread pathology-api/src/pathology_api/request_context.py Outdated
Comment thread pathology-api/src/pathology_api/request_context.py Outdated
Comment thread pathology-api/src/pathology_api/request_context.py Outdated
Comment thread pathology-api/src/pathology_api/test_handler.py
Comment thread pathology-api/src/pathology_api/test_pdm.py Outdated
Comment thread pathology-api/test_lambda_handler.py
Copy link
Copy Markdown
Collaborator

@nhsd-jack-wainwright nhsd-jack-wainwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a couple additional suggestions.

Comment thread pathology-api/lambda_handler.py Outdated
Comment thread pathology-api/tests/integration/test_endpoints.py
@MohammadPatelNHS MohammadPatelNHS force-pushed the feature/CDAPI-72 branch 2 times, most recently from 40465e6 to 04519be Compare April 17, 2026 10:12
@MohammadPatelNHS MohammadPatelNHS marked this pull request as ready for review April 17, 2026 10:37
@MohammadPatelNHS MohammadPatelNHS requested review from a team as code owners April 17, 2026 10:37
Base automatically changed from feature/CDAPI-113 to main April 20, 2026 09:50
@nhsd-jack-wainwright nhsd-jack-wainwright dismissed their stale review April 20, 2026 09:50

The base branch was changed.

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

Deployment Complete

@MohammadPatelNHS MohammadPatelNHS merged commit 8ef7b10 into main Apr 20, 2026
39 checks passed
@MohammadPatelNHS MohammadPatelNHS deleted the feature/CDAPI-72 branch April 20, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants